Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mdspan>: Make extents truly empty when rank_dynamic() == 0 #3825

Merged
merged 4 commits into from
Jul 3, 2023
Merged

<mdspan>: Make extents truly empty when rank_dynamic() == 0 #3825

merged 4 commits into from
Jul 3, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Jun 23, 2023 •
edited
Loading

  • Introduce _Calculate_rank_dynamic template variable for easier rank_dynamic() computations,
  • Introduce _Maybe_empty_array - a base class for std::extents and (in the future) for std::layout_stride::mapping,
  • Remove extents::_Static_extents_only and extents::_Dynamic_extents,
  • Add tests.

@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner June 23, 2023 13:51
@JMazurkiewicz
<mdspan>: Make extents truly empty when rank_dynamic() == 0
b41de37 
* Introduce `_Calculate_rank_dynamic` template variable for easier `rank_dynamic()` computations,
* Introduce `_Dynamic_extents_array` - a base class for `std::extents`,
* Remove `extents::_Static_extents_only` and `extents::_Dynamic_extents`,
* Add tests.
@StephanTLavavej StephanTLavavej added the mdspan C++23 mdspan label Jun 30, 2023
StephanTLavavej
StephanTLavavej approved these changes Jul 3, 2023
View reviewed changes
stl/inc/mdspan Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the performance Must go faster label Jul 3, 2023
@StephanTLavavej StephanTLavavej merged commit 2a12d44 into microsoft:feature/mdspan2 Jul 3, 2023
@StephanTLavavej
Copy link
Member

Awesome, thank you! I had one suggestion for followup. 😻 🎉

@JMazurkiewicz JMazurkiewicz deleted the mdspan/ebo-extents branch July 3, 2023 23:19
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Jul 4, 2023
@JMazurkiewicz
Address microsoft#3825 (comment)
7e7c09e
JMazurkiewicz added a commit to JMazurkiewicz/STL that referenced this pull request Jul 5, 2023
@JMazurkiewicz
Address microsoft#3825 (comment)
02980fd
@JMazurkiewicz JMazurkiewicz mentioned this pull request Jul 5, 2023
Merged
@StephanTLavavej StephanTLavavej mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees
No one assigned
Labels
mdspan C++23 mdspan performance Must go faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JMazurkiewicz @StephanTLavavej